If it is as you say, then in such case, you can remove all the tests

Or the test could be changed to adress field instead of last_name.

In our current working version empty() was replaced by strlen() test, but the logics should be still same.

The reason for this test was, that the data in VM can be a bit inconsistent sometimes and it occured that incomplete information was shown. That is why this test was in place.

Hi Jan
Not wishing to tell you how things should work... but more of a logical question.

Would it not be better to see if "ST" has been set for an order_id?
This way, if it exists then use it, Else use the default?
If it is set and other conditions apply, i.e. bothi or both, or both and ST etc. then write the code....
There are currently 16 possible combinations to use, although if bothi is set then this appears to shortcut a few?
Just a thought.

Obviously, that is also a possibility. I think this problem was based on a wrong assuption that the last_name as compulsory field has to be always set for an address in VM.

We will change the test to order_id and release a new patch. Then I guess, it should be working fine for you.

Hi Jan
Is it just my install or is this a component issue?

I am not sure. There was one another user complaining about this, so it may be more general problem.

Anyway, we have released 1.4.7 where we have updated the code, so you may test it.

Hi Jan
I have upgraded to .7.

OK.
The delivery now seems to be working ok.
On "VM Invoice: Order List" page it would be good to have the client name and email address shown.
This is obviously due to the same issue as with the ST and BT as we have just resolved, but now relative to the admin page and not the pdf's.

Also I have had to insert £ for each instance of the sub totals and totals...


The £ sign gets displayed correctly in the pdfs now but this is not ideal as the core files have been hacked.
What part of the above code is supposed to display the symbol?
I did echo $currency to test and it just displayed GBP which is not the symbol.